Repository navigation
[PWGCF] Addition of PID specific long-range correlations - #17940
Merged
Merged
Conversation
|
O2 linter results: ❌ 0 errors, |
Preet-Bhanjan
marked this pull request as ready for review
September 16, 2026 18:03
Preet-Bhanjan
requested review from
alibuild,
dsarkaralice,
jaelpark,
lauraser,
victor-gonzalez and
wenyaCern
as code owners
September 16, 2026 18:03
Collaborator
|
Error while checking build/O2Physics/code-check for 367d126 at 2026-09-17 04:09: Full log here. |
Collaborator
|
Error while checking build/O2Physics/staging for 367d126 at 2026-09-17 04:14: Full log here. |
Collaborator
|
Error while checking build/O2Physics/o2 for 367d126 at 2026-09-17 04:45: Full log here. |
Preet-Bhanjan
force-pushed
the
master
branch
from
September 17, 2026 04:53
367d126 to
e54c43f
Compare
Collaborator
Collaborator
|
Error while checking build/O2Physics/code-check for e54c43f at 2026-09-26 12:34: Full log here. |
Collaborator
|
@Preet-Bhanjan Please fix the errors and warnings before merging. |
Collaborator
|
Error while checking build/O2Physics/staging for 0596a44 at 2026-10-01 21:53: Full log here. |
Collaborator
|
Error while checking build/O2Physics/o2 for 0596a44 at 2026-10-01 22:21: Full log here. |
vkucera
marked this pull request as draft
October 1, 2026 20:28
Collaborator
|
Please test your changes locally before pushing them to the PR. |
Collaborator
|
Error while checking build/O2Physics/code-check for 0596a44 at 2026-10-01 22:44: Full log here. |
Contributor
Author
|
Dear reviewers, |
vkucera
reviewed
Oct 5, 2026
| std::array<std::array<float, 3>, 6> nSigmaVals{}; | ||
|
|
||
| // define global variables | ||
| TRandom3* gRandom = new TRandom3(); |
Collaborator
There was a problem hiding this comment.
Why do you need to allocate this member dynamically?
vkucera
reviewed
Oct 5, 2026
Comment on lines
+263
to
+266
| enum FITIndex { | ||
| kFT0A = 0, | ||
| kFT0C = 1 | ||
| }; |
Collaborator
There was a problem hiding this comment.
The k prefix is not allowed by the O2 naming conventions.
vkucera
reviewed
Oct 5, 2026
Comment on lines
+277
to
+284
| enum PiKpArrayIndex { | ||
| iPionUp = 0, | ||
| iKaonUp, | ||
| iProtonUp, | ||
| iPionLow, | ||
| iKaonLow, | ||
| iProtonLow | ||
| }; |
Collaborator
There was a problem hiding this comment.
Enumerator values should follow the UpperCamelCase naming style.
vkucera
reviewed
Oct 5, 2026
Comment on lines
+410
to
+413
| cfgFuncParas.fMultPVT0CCutLow = new TF1("fMultPVT0CCutLow", cfgFuncParas.cfgMultCentLowCutFunction->c_str(), 0, 100); | ||
| cfgFuncParas.fMultPVT0CCutLow->SetParameters(cfgFuncParas.multPVT0CCutPars.data()); | ||
| cfgFuncParas.fMultPVT0CCutHigh = new TF1("fMultPVT0CCutHigh", cfgFuncParas.cfgMultCentHighCutFunction->c_str(), 0, 100); | ||
| cfgFuncParas.fMultPVT0CCutHigh->SetParameters(cfgFuncParas.multPVT0CCutPars.data()); |
Collaborator
There was a problem hiding this comment.
Where do you delete these objects?
Collaborator
Dear @Preet-Bhanjan , not sure how to help about this. I suppose you tested your changes on macOS, right? |
Contributor
Author
Dear @vkucera, Yes, I used macOS (version 26.6) to test my changes. |
Preet-Bhanjan
marked this pull request as ready for review
October 7, 2026 08:04
Collaborator
|
Error while checking build/O2Physics/staging for 66ddf2b at 2026-10-07 10:19: Full log here. |
Collaborator
Can you try to count the members of your |
Preet-Bhanjan
marked this pull request as draft
October 7, 2026 09:03
Collaborator
|
Error while checking build/O2Physics/code-check for 66ddf2b at 2026-10-07 11:27: Full log here. |
Collaborator
|
Error while checking build/O2Physics/o2 for 66ddf2b at 2026-10-07 12:09: Full log here. |
Contributor
Author
Dear @vkucera There are 94 members in my struct. I will try to decrease them. |
Collaborator
Thanks for checking. If I remember correctly, the maximum is 99, so that should not be a problem. Let me double-check. |
Collaborator
Well, I counted 96 data members + 28 methods + 5 process switches. That's 129 members. |
Preet-Bhanjan
marked this pull request as ready for review
October 7, 2026 13:59
Preet-Bhanjan
marked this pull request as draft
October 7, 2026 14:08
Preet-Bhanjan
marked this pull request as ready for review
October 7, 2026 14:35
Collaborator
|
Error while checking build/O2Physics/code-check for 6c08a9a at 2026-10-07 18:24: Full log here. |
Preet-Bhanjan
marked this pull request as draft
October 7, 2026 19:33
Preet-Bhanjan
marked this pull request as ready for review
October 7, 2026 19:41
wenyaCern
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.